Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when opening NXM link before selecting instance #2144

Merged

Conversation

JonathanFeenstra
Copy link
Contributor

Fixes #2121. Implementing #1531 would be more complicated, since we'd have to consider more edge cases (e.g. what to do when there are multiple instances found for the game from the downloaded mod).

src/moapplication.cpp Outdated Show resolved Hide resolved
@Holt59 Holt59 merged commit c44ee31 into ModOrganizer2:master Oct 15, 2024
2 checks passed
@JonathanFeenstra JonathanFeenstra deleted the select-instance-before-download branch October 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting download via NXM with no instance crashes MO2.
2 participants